Tech Review MoM - Automation

Owned by Pundaleek H (Unlicensed)
Last updated: Jan 12, 2021
2 min read

Date:

2nd Dec 2020

Participants :

@Hamsa Nandini @Bhavana Vasudev @Sarita Mohapatra @Shareef Shaik @Sathish P @Tarun Lalwani @Pundaleek H (Unlicensed) @Yatheendra BC @Krishnendu Halder

Discussion Topics:

  • Code walk through to the team.

Action Items:

  • Tags naming conventions. (Add tag for positive/negative/smoke and keep it separate as config file or somewhere else.) - Done

  • Reading tags from different config file. - Pending

  • Mapping automation and manual tests. - Done

  • No hard coded value inside the scripts. - Done

  • Folder structure of payload request should be changed. - Done

  • Http status 500 test cases should not be automated. - Done

  • RequestInfo as of now can use only authToken. - Done

  • There should be a common url in yaml file for framework config. Other services should be segregated. Environment config and framework config should be segregated. - Done

  • if any parameters are there will use in separate template. - Done

  • Push the code on daily bases. - Yes

Demo Findings - 7th Dec 2020

  • Code clean up - Done

  • Segregate service - Done

  • Create the folder structure of json request - Done

  • Create folder structure of constants - Done

  • Add separate folder for userdetails - Done

  • Add tags - Done

Demo Findings - 9th Dec 2020

  • Created the folder structure -Done

  • Created single constant file for each service - Done

  • Added all the common service in to the common.yaml - Done

  • Created .yaml file for each env -Done

  • Added host, state level host and tenantid in uat

  • Removed requestinfo from json -Done

  • Removed response json - Done

  • Created separate folder for test data - Done

  • Kept the env folder outside the sourcefile - Done

  • User creation - Done

Tech Review - 8th Jan 2021

  • Naming conventions across all files.

  • Grouping of end points in common.yaml file.

  • Remove invalid url related automation tests.

Current Git Branch :

https://github.com/egovernments/test-automation/tree/automation-phase-0

Internal Code Review Comments - 11th Jan 2021

  1. Git Commits Branch - Find Comments for More Details

High Level Comments as Below - Click above link for more detail info about review comments

  • Add comma (,) after userotp in tags before hrms

  • Comment is misleading if I am not wrong. can you update or remove.

  • Instead of expectedMessage1, please use proper naming convention what exactly it refers to.

  • tagName & Scenario both are misleading. please change it accordingly.

  • Can we add this in hrms.yaml if possible instead of hard-coding here?

 

2. Git Commits Branch - Find Comments for More Details

High Level Comments as Below - Click above link for more detail info about review comments

  • invalidTenantId and invalidAuthToken repeating in every yaml file. in such cases we can keep this in other file where all such constants are present or else you create one and add all repeated parameters across all endpoints in that file.

  • Where are messages? - means expected messages are missing. There is only placeholder created.

  • Keep proper naming for files. don't use like sample.pdf etc

  • Invalid service is not required

  • Remove this still code will work : def javaUtils = Java.type('com.egov.base.EGovTest')

  • Remove commented lines if not in use

  • Comment should be localization upsert json

  • Read it from yaml file.

 

Internal Code Review Comments - 13th Jan 2021

  1. Access Control Tests - Find Comments for More Details