Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • invalidTenantId and invalidAuthToken repeating in every yaml file. in such cases we can keep this in other file where all such constants are present or else you create one and add all repeated parameters across all endpoints in that file.

  • Where are messages? - means expected messages are missing. There is only placeholder created.

  • Keep proper naming for files. don't use like sample.pdf etc

  • Invalid service is not required

  • Remove this still code will work : def javaUtils = Java.type('com.egov.base.EGovTest')

  • Remove commented lines if not in use

  • Comment should be localization upsert json

  • Read it from yaml file.

Internal Code Review Comments - 13th Jan 2021

  1. Access Control Tests - Find Comments for More Details