...
https://github.com/egovernments/test-automation/tree/automation-phase-0
Internal Code Review Comments - 11th Jan 2021
High Level Comments as Below - Click above link for more detail info about review comments
Add comma (,) after userotp in tags before hrms
Comment is misleading if I am not wrong. can you update or remove.
Instead of expectedMessage1, please use proper naming convention what exactly it refers to.
tagName & Scenario both are misleading. please change it accordingly.
Can we add this in hrms.yaml if possible instead of hard-coding here?
2. Git Commits Branch - Find Comments for More Details
High Level Comments as Below - Click above link for more detail info about review comments
invalidTenantId and invalidAuthToken repeating in every yaml file. in such cases we can keep this in other file where all such constants are present or else you create one and add all repeated parameters across all endpoints in that file.
Where are messages? - means expected messages are missing. There is only placeholder created.
Keep proper naming for files. don't use like sample.pdf etc
Invalid service is not required
Remove this still code will work :
def javaUtils = Java.type('com.egov.base.EGovTest')Remove commented lines if not in use
Comment should be localization upsert json
Read it from yaml file.